Fix: ignore undefined values in schema properties#2582
Open
veeceey wants to merge 2 commits intoajv-validator:masterfrom
Open
Fix: ignore undefined values in schema properties#2582veeceey wants to merge 2 commits intoajv-validator:masterfrom
veeceey wants to merge 2 commits intoajv-validator:masterfrom
Conversation
da81290 to
46c435e
Compare
Author
|
gentle ping — would be great to get some eyes on this when possible |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #2578 where schemas with undefined property values (commonly from destructuring) cause ajv to throw a TypeError instead of ignoring them.
Before:
After:
Changes
allSchemaProperties()inlib/vocabularies/code.tsto filter out undefined valuesTest Coverage
The fix includes tests for:
Manual Testing
Verified the fix handles:
Closes #2578