added comments explaining problems/fixes and did some mild formatting#1
Open
razzdrgn wants to merge 1 commit intoakandic47:masterfrom
Open
added comments explaining problems/fixes and did some mild formatting#1razzdrgn wants to merge 1 commit intoakandic47:masterfrom
razzdrgn wants to merge 1 commit intoakandic47:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Biggest problem was that you weren't storing the output of the reqwest get call anywhere, so throwing it into a variable called resp fixes most of the problems there (and probably gets the error you originally asked for resolved since you're actually doing something with the future)
You're also importing way too many things for this task, and can remove plenty of things from it, since you don't need most of what you have there.
If you're still having trouble let me know but this commit merge should put you at a good place to process the response object into the solution.