Closed
Conversation
Contributor
Author
|
@troian This PR is now just for |
Contributor
Author
|
@troian Can you take a look at https://github.com/akash-network/provider/pull/232/files#diff-ad05e1c650e40b9d96f8e6be2ce651a482926400144ddfe3c90363c23a449379R35-R36. I'm assuming we ignore this value for streaming the logs? |
Contributor
Author
Never mind, I found where it's used, and it's ignored if |
Contributor
Author
|
@troian This PR will now contain all gRPC endpoint changes. |
Signed-off-by: Andrew Hare <andrewhare@users.noreply.github.com>
added 2 commits
May 1, 2024 21:11
Contributor
Author
|
@troian This is ready for final review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves akash-network/support#221
Relies on akash-network/akash-api#164
Convert REST handlers to gRPC.
LeaseServiceSendManifest: On hold (Lease service:SendManifest#212)Status: DoneStreamStatus: DoneShell: Out of scope for this PRLogs: DoneStreamLogs: DoneProviderServiceGetStatus: DoneStreamStatus: DoneGetVersion: DoneValidate: DoneWIBOY: DoneNOTE
This PR has
akash-apimanually pinned to the PR commit. Once akash-network/akash-api#164 is merged, that will be need to be undone.