Fixed Notification Translate

Signed-off-by: Akhil Kedia <akhilkedia94@gmail.com>
akhilkedia · Dec 29, 2021 · 0e275ac · 0e275ac
1 parent 790da2b
commit 0e275ac
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 8 deletions.
diff --git a/app/src/main/java/akhil/alltrans/NotificationHookHandler.java b/app/src/main/java/akhil/alltrans/NotificationHookHandler.java
@@ -285,9 +285,7 @@ private void changeText(Notification notification, String originalString, String
     protected Object replaceHookedMethod(MethodHookParam methodHookParam) throws Throwable {
         utils.debugLog("Notification : in notificationhook ");
         Notification notification = (Notification) methodHookParam.args[methodHookParam.args.length - 1];
-        Object[] userDataOut = new Object[3];
-        userDataOut[0] = methodHookParam;
-        userDataOut[1] = "";
+        NotificationHookUserData userDataOut = new NotificationHookUserData(methodHookParam, "");
         callOriginalMethod("", userDataOut);
 
         CharSequence[] allNotificationTexts = getAllText(notification);

diff --git a/app/src/main/java/akhil/alltrans/PreferenceList.java b/app/src/main/java/akhil/alltrans/PreferenceList.java
@@ -76,7 +76,7 @@ public static void getPref(String globalPref, String localPref, String packageNa
         SetHint = (boolean) getValue(gPref, "SetHint", true);
         LoadURL = (boolean) getValue(gPref, "LoadURL", true);
         DrawText = (boolean) getValue(gPref, "DrawText", false);
-        Notif = (boolean) getValue(gPref, "Notif", false);
+        Notif = (boolean) getValue(gPref, "Notif", true);
 
         Caching = (boolean) getValue(gPref, "Cache", true);
         Delay = Integer.parseInt((String) getValue(gPref, "Delay", "0"));

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -109,9 +109,9 @@
     <string name="webView_summary_on">"Translating Text inside WebView - Safe, May Not Work Always. Turn off to disable."</string>
 
     <!-- notif -->
-    <string name="notif">"Translate Notifications (Unstable, May Crash)"</string>
+    <string name="notif">"Translate Notifications"</string>
     <string name="notif_summary_off">"Not Translating Text in Notifications. Turn on to enable."</string>
-    <string name="notif_summary_on">"Translating Text inside Notifications - Unstable, May Crash Apps. Turn off to disable."</string>
+    <string name="notif_summary_on">"Translating Text inside Notifications - Safe, May sometimes crash apps. Turn off to disable."</string>
 
     <!-- drawText -->
     <string name="drawText">"Aggressive Mode"</string>

diff --git a/app/src/main/res/xml/perappprefs.xml b/app/src/main/res/xml/perappprefs.xml
@@ -130,7 +130,7 @@
             android:title="@string/caching" />
         <SwitchPreference
             app:iconSpaceReserved="false"
-            android:defaultValue="false"
+            android:defaultValue="true"
             android:key="Notif"
             android:summaryOff="@string/notif_summary_off"
             android:summaryOn="@string/notif_summary_on"

diff --git a/app/src/main/res/xml/preferences.xml b/app/src/main/res/xml/preferences.xml
@@ -126,7 +126,7 @@
             android:title="@string/webView" />
         <SwitchPreference
             app:iconSpaceReserved="false"
-            android:defaultValue="false"
+            android:defaultValue="true"
             android:key="Notif"
             android:summaryOff="@string/notif_summary_off"
             android:summaryOn="@string/notif_summary_on"