chore: don't fail deserialization on unknown event metadata #32812
Conversation
|
Could be that we need more tuning, logging or opt in/out |
| serialization | ||
| .deserialize(persistentPayload.getPayload.toByteArray, persistentPayload.getSerializerId, manifest) | ||
| .get | ||
| .toOption |
There was a problem hiding this comment.
Shall we have a marker trait to define that the metadata is mandatory and should fail deserialization instead of skipping? Then we have it as default to ignore, but can mark certain things, like ReplicatedEventMetadata.
There was a problem hiding this comment.
We only have a serializer id and a manifest, no class on the deserializing side when unknown metadata type so we couldn't know that the marker is applied?
There was a problem hiding this comment.
yeah, didn't think (that far)
There was a problem hiding this comment.
I was thinking that it could be only for unknown serializer id:s but where we hit it ourselves was there is an existing serializer for protos but the message type is unknown, so that doesn't work well enough either.
|
Was thinking about logging as a warning on first occurrence per serializer id + manifest, and still ignore, but that wouldn't help our SDK users defining custom metadata, warning would go in runtime logs. |
|
New idea, probably with a toggle to enable, we could collect such failures in a special kind of public API metadata entry, that it is then possible to look for in the events and deal with in a suitable way in a given application. |
References: