chore: Internal feature to intercept and emit additional events #32823
+283
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
patriknw
commented
Oct 24, 2025
patriknw
commented
- for replicated event sourcing
* for replicated event sourcing
patriknw
force-pushed
the
wip-res-intercept2-patriknw
branch
from
3d9afbb to
63c7d68
Compare
johanandren
reviewed
Nov 11, 2025
akka-persistence-typed/src/main/scala/akka/persistence/typed/internal/Running.scala
Outdated
Show resolved
Hide resolved
| val adaptedEvent = adaptEvent(currentState.state, event) | ||
|
|
||
| eventsToPersist = EventToPersist(adaptedEvent, evtManifest, metadata) :: eventsToPersist | ||
| } |
Contributor
There was a problem hiding this comment.
I don't love this style of mutation from inside foreach, vs a fold or something more pure, but I guess it is to keep it consistent since it needs to mutate multiple things?
Contributor
Author
There was a problem hiding this comment.
yeah, that style is taken from the existing handleEventPersistAll
it's mutating several things, including external things in the setup
Contributor
Author
|
added tests, and found/fixed one issue |
johanandren
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.