Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update remaining port mappings and format yaml #130

Merged
merged 2 commits into from
May 1, 2024
Merged

fix: update remaining port mappings and format yaml #130

merged 2 commits into from
May 1, 2024

Conversation

vordimous
Copy link
Contributor

No description provided.

@vordimous vordimous linked an issue Apr 24, 2024 that may be closed by this pull request
update tcp bindings to define a list of ports #129
Closed
@vordimous vordimous requested a review from jfallows April 30, 2024 18:50
jfallows
jfallows reviewed Apr 30, 2024
View reviewed changes
Copy link
Contributor

@jfallows jfallows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

Please add tls route by port to unify tls server for mqtt.kafka.broker scenario.

@vordimous
Copy link
Contributor Author

Please add tls route by port to unify tls server for mqtt.kafka.broker scenario.

Updated with port routing in the tls binding.

@vordimous
Copy link
Contributor Author

vordimous commented May 1, 2024 •
edited
Loading

@jfallows @bmaidics During testing of the mqtt.kafka.broker example I found the ws endpoints don't work anymore. I get the same result on main and with these changes.

Issue tracked in this ticket

@vordimous vordimous requested a review from jfallows May 1, 2024 14:59
@jfallows
Copy link
Contributor

jfallows commented May 1, 2024

@vordimous thanks, I've asked @bmaidics to take a look at this.

@jfallows jfallows merged commit 4368a59 into main May 1, 2024
2 checks passed
@vordimous vordimous deleted the 129-update-tcp-bindings-to-define-a-list-of-ports branch November 7, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfallows jfallows jfallows approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update tcp bindings to define a list of ports
2 participants
@vordimous @jfallows