Address review items

aklivity · Jun 18, 2024 · fb43725 · fb43725
1 parent 47de06c
commit fb43725
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 13 deletions.
diff --git a/...java/io/aklivity/zilla/runtime/binding/asyncapi/internal/config/AsyncapiHttpProtocol.java b/...java/io/aklivity/zilla/runtime/binding/asyncapi/internal/config/AsyncapiHttpProtocol.java
@@ -118,16 +118,19 @@ public <C> BindingConfigBuilder<C> injectProtocolServerRoutes(
                         if (operation.bindings != null)
                         {
                             AsyncapiBinding httpBinding = operation.bindings.get("http");
-                            String method = httpBinding.method;
-                            binding
-                                .route()
-                                .exit(qname)
-                                .when(HttpConditionConfig::builder)
-                                    .header(":path", path)
-                                    .header(":method", method)
-                                    .build()
-                                .inject(route -> injectHttpServerRouteGuarded(route, server))
-                                .build();
+                            if (httpBinding != null)
+                            {
+                                String method = httpBinding.method;
+                                binding
+                                    .route()
+                                    .exit(qname)
+                                    .when(HttpConditionConfig::builder)
+                                        .header(":path", path)
+                                        .header(":method", method)
+                                        .build()
+                                    .inject(route -> injectHttpServerRouteGuarded(route, server))
+                                    .build();
+                            }
                         }
                     }
                 }

diff --git a/...va/io/aklivity/zilla/runtime/binding/sse/kafka/config/SseKafkaConditionConfigBuilder.java b/...va/io/aklivity/zilla/runtime/binding/sse/kafka/config/SseKafkaConditionConfigBuilder.java
@@ -24,11 +24,12 @@ public final class SseKafkaConditionConfigBuilder<T> extends ConfigBuilder<T, Ss
     private final Function<ConditionConfig, T> mapper;
     private String path;
 
-    public SseKafkaConditionConfigBuilder(
+    SseKafkaConditionConfigBuilder(
         Function<ConditionConfig, T> mapper)
     {
         this.mapper = mapper;
     }
+
     public SseKafkaConditionConfigBuilder<T> path(
         String path)
     {

diff --git a/...in/java/io/aklivity/zilla/runtime/binding/sse/kafka/config/SseKafkaWithConfigBuilder.java b/...in/java/io/aklivity/zilla/runtime/binding/sse/kafka/config/SseKafkaWithConfigBuilder.java
@@ -29,7 +29,7 @@ public final class SseKafkaWithConfigBuilder<T> extends ConfigBuilder<T, SseKafk
     public List<SseKafkaWithFilterConfig> filters;
     public String eventId;
 
-    public SseKafkaWithConfigBuilder(
+    SseKafkaWithConfigBuilder(
         Function<WithConfig, T> mapper)
     {
         this.mapper = mapper;
@@ -56,7 +56,6 @@ public SseKafkaWithConfigBuilder<T> eventId(
         return this;
     }
 
-
     @Override
     @SuppressWarnings("unchecked")
     protected Class<SseKafkaWithConfigBuilder<T>> thisType()