grpc custom metadata passthrough implementation #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
requested changes
Jun 26, 2024
There was a problem hiding this comment.
This PR seems to be using text based metadata exclusively.
How do we plan to handle binary metadata via kafka message headers?
For example, how could we tell we need to decode a kafka message header as grpc binary vs text?
Btw, for end to end testing, don't we also need changes in kafka-grpc binding to support binary and text metadata?
...java/io/aklivity/zilla/runtime/binding/grpc/kafka/internal/stream/GrpcKafkaProxyFactory.java
Outdated
Show resolved
Hide resolved
...io/aklivity/zilla/runtime/binding/grpc/kafka/internal/config/GrpcKafkaWithProduceResult.java
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Jul 1, 2024
...io/aklivity/zilla/runtime/binding/kafka/grpc/internal/stream/KafkaGrpcFetchHeaderHelper.java
Outdated
Show resolved
Hide resolved
...io/aklivity/zilla/runtime/binding/kafka/grpc/internal/stream/KafkaGrpcFetchHeaderHelper.java
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Jul 8, 2024
...s/io/aklivity/zilla/specs/binding/grpc/kafka/streams/grpc/produce/bidi.stream.rpc/client.rpt
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Jul 9, 2024
...io/aklivity/zilla/runtime/binding/grpc/kafka/internal/config/GrpcKafkaWithProduceResult.java
Outdated
Show resolved
Hide resolved
...java/io/aklivity/zilla/runtime/binding/grpc/kafka/internal/stream/GrpcKafkaProxyFactory.java
Outdated
Show resolved
Hide resolved
...java/io/aklivity/zilla/runtime/binding/grpc/kafka/internal/stream/GrpcKafkaProxyFactory.java
Outdated
Show resolved
Hide resolved
...java/io/aklivity/zilla/runtime/binding/grpc/kafka/internal/stream/GrpcKafkaProxyFactory.java
Outdated
Show resolved
Hide resolved
...io/aklivity/zilla/runtime/binding/grpc/kafka/internal/config/GrpcKafkaWithProduceResult.java
Outdated
Show resolved
Hide resolved
...io/aklivity/zilla/runtime/binding/kafka/grpc/internal/stream/KafkaGrpcFetchHeaderHelper.java
Outdated
Show resolved
Hide resolved
.../aklivity/zilla/runtime/binding/kafka/grpc/internal/stream/KafkaGrpcRemoteServerFactory.java
Outdated
Show resolved
Hide resolved
.../aklivity/zilla/runtime/binding/kafka/grpc/internal/stream/KafkaGrpcRemoteServerFactory.java
Outdated
Show resolved
Hide resolved
.../aklivity/zilla/runtime/binding/kafka/grpc/internal/stream/KafkaGrpcRemoteServerFactory.java
Outdated
Show resolved
Hide resolved
...ing-grpc.spec/src/main/java/io/aklivity/zilla/specs/binding/grpc/internal/GrpcFunctions.java
Outdated
Show resolved
Hide resolved
jfallows
previously approved these changes
Jul 10, 2024
jfallows
requested changes
Jul 15, 2024
...java/io/aklivity/zilla/runtime/binding/grpc/kafka/internal/stream/GrpcKafkaProxyFactory.java
Outdated
Show resolved
Hide resolved
.../io/aklivity/zilla/specs/binding/grpc/kafka/streams/grpc/fetch/reliable.unary.rpc/client.rpt
Outdated
Show resolved
Hide resolved
jfallows
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #730