Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support karapace-schema-registry, schema-registry and apicurio-registry catalogs #1134

Merged
merged 8 commits into from
Jul 15, 2024
Merged

Support karapace-schema-registry, schema-registry and apicurio-registry catalogs #1134

merged 8 commits into from
Jul 15, 2024

Conversation

jfallows
Copy link
Contributor

@jfallows jfallows commented Jul 4, 2024 •
edited
Loading

Catalog naming updates.

schema-registry (added)
karapace renamed karapace-schema-registry (retained karapace alias)
apicurio renamed apicurio-registry (retained apicurio alias)

Note: catalog events always use their canonical name prefix even when a type alias is used in zilla.yaml configuration.

@jfallows jfallows requested review from vordimous and ankitk-me July 4, 2024 04:37
vordimous
vordimous previously approved these changes Jul 6, 2024
View reviewed changes
Copy link
Contributor

@vordimous vordimous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall changes LTGM

@jfallows jfallows requested a review from vordimous July 9, 2024 05:58
vordimous
vordimous previously approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@vordimous vordimous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@jfallows jfallows requested a review from vordimous July 9, 2024 16:53
@jfallows jfallows changed the title Support karapace-schema-registry and schema-registry catalogs Support karapace-schema-registry, schema-registry and apicurio-registry catalogs Jul 9, 2024
vordimous
vordimous approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@vordimous vordimous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfallows jfallows marked this pull request as ready for review July 9, 2024 21:32
@jfallows jfallows merged commit 4071f1f into aklivity:develop Jul 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vordimous vordimous vordimous approved these changes

@ankitk-me ankitk-me Awaiting requested review from ankitk-me

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfallows @vordimous