Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lib usage #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Lib usage #29

wants to merge 1 commit into from

Conversation

odra
Copy link

@odra odra commented Apr 26, 2017

Hello,

The plugin hook does not fire when you directly execute it from the cordova-lib cordova.raw.prepare (it only works from the cordova cli - cordova prepare), this change enables the trigger from both cordova cli and cordova-lib.

Do you think this change makes sense?

Regards,

@camilamacedo86
Copy link

@akofman could you check it for us? Can you merge it?

@dcousens
Copy link

@odra don't include the npm build, typically the maintainer will do it anyway and its a security issue

@odra
Copy link
Author

odra commented May 10, 2017

@dcousens removed :)

@akofman
Copy link
Owner

akofman commented May 10, 2017

Hello @odra, thanks for this PR. As it is described in the comment : This script has to be executed depending on the command line arguments, not on the hook execution cycle.

To be honest I don't remember exactly why but I know that the after_prepare hook is triggered even from other hooks and can implies multiple runs of this script. I think the settings were not well updated in the end.

I'm going to check an other way to do that and keep you in touch. Did you try to check directly cordova.raw.prepare ?

@odra
Copy link
Author

odra commented May 10, 2017

Hello @akofman, thanks for the reply.

I do remember this being triggered more than once when using cordova cli but I think this validates to false when directly using cordova.raw.prepare (which is what I am using): context.cmdLine.includes('prepare')

@dcousens
Copy link

dcousens commented Oct 4, 2018

Rebase or close?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@odra
Copy link
Author

odra commented Oct 4, 2018

@dcousens just rebased it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants