-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lib usage #29
base: master
Are you sure you want to change the base?
Lib usage #29
Conversation
@akofman could you check it for us? Can you merge it? |
@odra don't include the |
@dcousens removed :) |
Hello @odra, thanks for this PR. As it is described in the comment : To be honest I don't remember exactly why but I know that the I'm going to check an other way to do that and keep you in touch. Did you try to check directly |
Hello @akofman, thanks for the reply. I do remember this being triggered more than once when using cordova cli but I think this validates to |
Rebase or close? |
@dcousens just rebased it |
Hello,
The plugin hook does not fire when you directly execute it from the cordova-lib
cordova.raw.prepare
(it only works from the cordova cli -cordova prepare
), this change enables the trigger from both cordova cli and cordova-lib.Do you think this change makes sense?
Regards,