Update ng-pdfviewer.js #8
Conversation
Couple of changes made. One was to move canvas and instance_id into scope instead of being globally available. This allows multiple <pdfviewer> elements on a page or partial. Also changed the scope option for "id" to "@" to allow the "id" attribute to be manipulated by Angular models.
|
After trying to get multiple instances of the pdfviewer tags to work properly, found that the included changes work well and doesn't affect single instances. |
|
Does this work with the newest Angular version? I'm stuck at "angular": "~1.2.5",. |
|
It's working for me. I'm using Angular 1.2.16. Andy On Mon, May 26, 2014 at 9:19 AM, renege notifications@github.com wrote:
|
|
Ok. Strange: #9 |
|
Well I couldn't get it working with latest version of pdf.js if that's what Andy On Mon, May 26, 2014 at 11:45 AM, renege notifications@github.com wrote:
|
- currently using ng-pdfviewer from https://github.com/akrennmair/ng-pdfviewer/ - pdf links now opens new tab and display the pdf within a new AttachmentPDFController - The preferred way of displaying the pdfs is inline with the other content, especially for the judgement page. However currently this library only allows us to display one pdf per page. A fix has been made but has not been pulled into the master branch of the library. akrennmair/ng-pdfviewer#8
Couple of changes made. One was to move canvas and instance_id into scope instead of being globally available. This allows multiple elements on a page or partial. Also changed the scope option for "id" to "@" to allow the "id" attribute to be manipulated by Angular models.