-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New feature] Quote fetcher #8
base: main
Are you sure you want to change the base?
Conversation
@Glomels This feature is good but on testing, it seems like the Also, the placement looks fine but fonts and alignment seems to be lacking a lot in the current state of the feature. |
I'm using the same font as the buttons, seemed fine to me. |
I think it looks good this way. I decided to put a shorter character limit when on mobile view by getting the viewport width with javascript. |
Aesthetics were secondary. The major problem was with the quotes rapidly and randomly changing after a while. I'm actually viewing it on desktop currently, since I didn't plan a mobile version yet but yes, its good to see you already took it into account. No worries, I'll review it and make the required changes in a while. |
Display a quote at the top from a local array of quotes.
Click on the quote div to trigger a quote change.
Quote automatically changes every 15 seconds.
Limited to 150 character or less for responsive purposes.