MCP Recon code reusability added for tool, resource discovery, issue … #3286
Conversation
…fixed and capability added
| } | ||
|
|
||
| public static boolean useHostCondition(String hostName, HttpResponseParams.Source source) { | ||
| public static boolean useHostCondition(String hostName, HttpResponseParams.Source source, boolean isRecon) { |
There was a problem hiding this comment.
HttpResponseParams is already available everywhere. Instead of passing a new variable in all the places.
We can simply create a new source HttpResponseParams.Source.MCP_RECON
Your detection mechanism can set the source and here you can check for it.
This can in future be used by others or for fitlering( I think we do store the source somewhere )
There was a problem hiding this comment.
HttpResopnse param is a very widely used class, please do regression testing explicitly before deploying
Pipeline
Traffic Collector(daemonset) -> kafka -> Mini runtime -> Dashboard UI
- Make sure traffic ingestion is happening
- Make sure changes are backwards compatible.
There was a problem hiding this comment.
@nayanakto @aanchalakto I have not checked the rest of the code. Please review.
I just checked the hostCondition thing.
…fixed and capability added