use malicious event dao in main threat queries #3298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauravakto
reviewed
Oct 13, 2025
| KafkaConfig kafkaConfig, MaliciousEventDao maliciousEventDao) { | ||
| this.kafka = new Kafka(kafkaConfig); | ||
| this.mongoClient = mongoClient; | ||
| this.maliciousEventDao = maliciousEventDao; |
There was a problem hiding this comment.
Why do we need the Dao as a variable now ? We should directly use MaliciousEventsDao.instance.. ?
There was a problem hiding this comment.
as discussed keeping this
gauravakto
reviewed
Oct 13, 2025
|
|
||
| MaliciousEventService maliciousEventService = | ||
| new MaliciousEventService(internalKafkaConfig, threatProtectionMongo); | ||
| new MaliciousEventService(internalKafkaConfig, MaliciousEventDao.instance); |
There was a problem hiding this comment.
same why create dependency ? we can directly use MaliciousEventDao.instance ?
gauravakto
reviewed
Oct 13, 2025
| MongoCollection<Document> coll = database.getCollection(MongoDBCollection.ThreatDetection.MALICIOUS_EVENTS, Document.class); | ||
| public static void createIndexIfAbsent(String accountId, MaliciousEventDao maliciousEventDao) { | ||
| // Get the collection from DAO - this will create the collection if it doesn't exist | ||
| MongoCollection<?> collection = maliciousEventDao.getCollection(accountId); |
There was a problem hiding this comment.
dao.Instance
create indices for api_distirbution_data as well.
gauravakto
reviewed
Oct 13, 2025
| return super.getCollection(accountId); | ||
| } | ||
|
|
||
| public AggregateIterable<Document> aggregateRaw(String accountId, List<Document> pipeline) { |
There was a problem hiding this comment.
simly MaliciosDao.instance.aggregate won't work ?
gauravakto
reviewed
Oct 13, 2025
| long modifiedCount = coll.updateMany(query, update).getModifiedCount(); | ||
|
|
||
| long modifiedCount = maliciousEventDao.getCollection(accountId).updateMany(query, update).getModifiedCount(); |
There was a problem hiding this comment.
With Dao it should directly be Dao.instance.updateMany ???
gauravakto
reviewed
Oct 13, 2025
| .setDetectedAt(event.getDetectedAt()) | ||
| .setSubCategory(event.getFilterId()) | ||
| .setSeverity(event.getSeverity()) | ||
| .setMethod(event.getLatestApiMethod().name()) |
There was a problem hiding this comment.
check if latestApiMethod is an enum ? .name needed ?
gauravakto
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.