Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for Bitbucket provider in gitprovider #3209

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

feat: Add support for Bitbucket provider in gitprovider #3209

wants to merge 7 commits into from

Conversation

chamodshehanka
Copy link

@chamodshehanka chamodshehanka commented Jan 4, 2025 •
edited
Loading

Closes: #2569

Added support for Bitbucket provider in gitprovider.
For now I opened a WIP PR

TODO

  • Complete the convertBitbucketPR function
  • Handle the interface{} type - The Bitbucket library returns interface{} for some fields. You need to properly type assert these fields to extract the necessary information
  • Test the implementation

@chamodshehanka
feat: WIP: Add Bitbucket provider implementation
151f0d8 
Signed-off-by: chamodshehanka <hcsperera@gmail.com>
@chamodshehanka chamodshehanka requested a review from a team as a code owner January 4, 2025 16:34
@netlify Netlify
Copy link

netlify bot commented Jan 4, 2025 •
edited
Loading

✅ Deploy Preview for docs-kargo-io canceled.

Name Link
🔨 Latest commit 58ff091
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/67c1a400724ec20008813c1b

@chamodshehanka chamodshehanka marked this pull request as draft January 4, 2025 16:36
chamodshehanka and others added 3 commits January 5, 2025 11:55
@chamodshehanka @krancour
Updated GetPullRequest comment in internal/gitprovider/gitprovider.go
fe71a75 
Co-authored-by: Kent Rancourt <kent.rancourt@gmail.com>
@chamodshehanka
chore: Added method to struct to create pull requests in Bitbucket
9a5d401 
Signed-off-by: chamodshehanka <hcsperera@gmail.com>
@chamodshehanka
fix: Merge conflict resolved
8327b0c 
Signed-off-by: chamodshehanka <hcsperera@gmail.com>
@krancour krancour added this to the v1.3.0 milestone Feb 4, 2025
@chamodshehanka chamodshehanka changed the title [WIP] feat: Add support for Bitbucket provider in gitprovider feat: Add support for Bitbucket provider in gitprovider Feb 22, 2025
@krancour krancour modified the milestones: v1.3.0, v1.4.0 Feb 23, 2025
@chamodshehanka
Copy link
Author

chamodshehanka commented Mar 16, 2025 •
edited
Loading

@krancour could you please help/guide me to up and running this in local, so can test this implementation?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krancour krancour krancour left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@krancour krancour

@chamodshehanka chamodshehanka

Labels
area/controller kind/enhancement priority/low
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

Promotion / create PR feature for Bitbucket server
2 participants
@chamodshehanka @krancour