-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP(ui): AnalysisRun logs #3674
Conversation
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3674 +/- ##
==========================================
+ Coverage 21.79% 21.91% +0.11%
==========================================
Files 310 313 +3
Lines 64706 65167 +461
==========================================
+ Hits 14105 14283 +178
- Misses 49836 50117 +281
- Partials 765 767 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Looks good, we don't need "follow logs" though since these won't be live logs. |
…ranch 'origin' into Marvin9/feat-analysisrun-logs-ui
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Live tail would be a nice feature if you’re running a long-running integration test and want to know where it’s at in the process. |
closing this for #3682 because had some resolved merge conflicts that was crashing API server and I couldn't find why |
|
I agree, but it makes things way more complicated, and we decided it is better to keep things simple and deliver this feature now, even if it isn't perfect, verse waiting until it is perfect with all the features. So, we deliver it with the logs minus live streaming to start, and then we can come back to this when we have time, and add the live streaming feature later. In my opinion some logs are better than no logs. If we want live streaming of logs, it won't available in 1.4 and I really want to have logs for this, it is currently a pain without them. |
ui prototype for #3641
in Analysis run modal
Deep link full page
cc @jessesuen @kencochrane @krancour