Fully customize cover open/close texts and support "stopped" status #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an't differentiate between open/close and opening/closing. Generate a fake middle position when the motor controller is "stopped", to allow Home Assistant GUI to show both open and close buttons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mainly for addressing issues with zinguo.motor.mk01.
The current implementation's open and close texts are too wide. They can't differentiate between stationary status open/close, and moving status opening/closing. The custom config list is just appending with the default texts, which is not helpful at all.
This PR changed the code to fully take the custom config list if available, and fall back to the default texts when no custom config found.
Additionally, this motor has no current position property, but does have a "Stopped" status. We can use this status to generate a fake 50% position so that we can use Home Assistant GUI to further open or close the cover.