Skip to content

Compatibility: fix compiler errors #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2025
Merged

Compatibility: fix compiler errors #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions source/matplot/core/axes_object.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ namespace matplot {

explicit axes_object(axes_handle parent);

virtual ~axes_object() = default;

public:
virtual double xmax();
virtual double xmin();
Expand Down
4 changes: 2 additions & 2 deletions source/matplot/util/common.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -866,8 +866,8 @@ namespace matplot {

// Initial calculations
if (log) {
std::invalid_argument("Not implemented yet. The library does not "
"need that as it is.");
throw std::invalid_argument("Not implemented yet. The library does "
"not need that as it is.");
}

// Data range
Expand Down
7 changes: 4 additions & 3 deletions source/matplot/util/common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,9 +605,10 @@ namespace matplot {
/// \brief Helper method for determining the whole array size.
/// Required for caching inner vector's size.
std::size_t calculate_size(const vector_2d &vec) {
return std::accumulate(
vec.begin(), vec.end(), (std::size_t)(0),
[](auto cnt, const auto &vec) { return cnt + vec.size(); });
return std::accumulate(vec.begin(), vec.end(), (std::size_t)(0),
[](auto cnt, const auto &inner_vec) {
return cnt + inner_vec.size();
});
}

public:
Expand Down