fix: Supports NotifyNowPlayingUpdated pushes
#2827
Open
+131
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports `NotifyNowPlayingUpdated` pushes, which are not yet supported in AMP. This will prevent frequent calls to `alexa_api.get_state()`, which was causing errors. This will likely fix alandtse#282.
for more information, see https://pre-commit.ci
nao-pon
changed the title
NotifyNowPlayingUpdated pushesNotifyNowPlayingUpdated pushes
…ayer into SupportNowPlaying
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…ayer into SupportNowPlaying
|
If you're still modifying the PR, please mark the PR as a draft so we don't begin review or merge it while incomplete. |
|
@alandtse Thank you. I thought it was good when I created the PR, but it seems that it hasn't been tested in practice yet. I'll change the status to draft and continue testing it a bit more. |
for more information, see https://pre-commit.ci
…ayer into SupportNowPlaying
…vent Spotify data may not be accepted unless it is a partial match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports
NotifyNowPlayingUpdatedpushes, which are not yet supported in AMP. This will prevent frequent calls toalexa_api.get_state(), which was causing errors. This will likely fix #2821 .