Ghc 9.12 delta ast #139
Merged
Ghc 9.12 delta ast #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nested structures not at the top level end up with DifferentLine column offsets that are different from the top level ones, because the top level offset was incorrect. It does break some low-level transform tests though
tests/Test/Transform.hs:88 AddLocalDecl5.hs tests/Test/Transform.hs:88 RmDecl4.hs Cases: 3518 Tried: 3518 Errors: 0 Failures: 2
Both legs of the condition did the same thing, keep one of those only
And the problem has to do with the indent after the new where clause. It works fine for no comment. The LayoutOffset is being used, where it should not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Harmonise calculation of delta offsets for top level and embedded offsets.