-
Notifications
You must be signed in to change notification settings - Fork 0
Auto-update doc build config #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughIncreases the pipeline timeout in .builds/doc-build.yaml from 1 hour to 2 hours within spec.runTemplate.spec.timeouts. No other changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.builds/doc-build.yaml (1)
6-8
: Consider explicitly setting tasks/finally timeouts to avoid abrupt cancellation of cleanups.If the whole pipeline gets 2h, it’s often useful to reserve a few minutes for
finally
steps and constrain task runs. This helps ensure finalizers still execute even when tasks approach the overall cap.Suggested tweak:
timeouts: - pipeline: 2h + pipeline: "2h" + tasks: "1h55m" + finally: "5m"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.builds/doc-build.yaml
(1 hunks)
🔇 Additional comments (2)
.builds/doc-build.yaml (2)
7-7
: LGTM: Timeout bump to 2h is straightforward and aligns with the PR intent.No structural or schema red flags in this line; value reads as a Go-style duration and should be acceptable by the controller assuming compatible Tekton/Katanomi versions.
7-7
: Confirm Tekton timeout syntax and cluster defaultsTekton parses Go duration strings directly, so unquoted 2h is valid, but it’s best practice to quote values in YAML (e.g.,
spec: runTemplate: spec: timeouts: pipeline: "2h"or
"2h0m0s"
) to avoid any YAML parsing edge cases.
- Ensure your
PipelineRun
actually contains that timeout field (runkubectl get pipelinerun <name> -o yaml
and look forspec.timeouts.pipeline
).- Tekton’s default-timeout-minutes (in the
config-defaults
ConfigMap in namespacetekton-pipelines
, or via the operator’sTektonConfig
) defaults to 60 minutes when no timeout is set explicitly. You can raise this default by editing that ConfigMap or CR.- There’s no hard-coded 1 hour cap—longer durations (e.g.,
"2h30m0s"
) are honored if they’re set. If you still see 1 hour timeouts, verify your Tekton version and check for any admission controllers or tooling (Katanomi/Triggers/Dashboard/CLI) that might be stripping or overriding the timeout.Please update your
.builds/doc-build.yaml
accordingly and verify on-cluster behavior.
auto update doc build config for doc pipeline
Summary by CodeRabbit