refactor(quality): ♻️ rewrite compareTo without relying on `runtime…

…Type` (#594) Signed-off-by: Albert Mañosa <26429103+albertms10@users.noreply.github.com>
albertms10 · Feb 22, 2025 · 2c5d5b9 · 2c5d5b9
1 parent dc9119e
commit 2c5d5b9
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/lib/src/interval/quality.dart b/lib/src/interval/quality.dart
@@ -61,9 +61,15 @@ sealed class Quality implements Comparable<Quality> {
   @override
   int compareTo(Quality other) => compareMultiple([
     () => semitones.compareTo(other.semitones),
-    // TODO(albertms10): rewrite without relying on `runtimeType`.
-    // ignore: no_runtimetype_tostring
-    () => '$runtimeType'.compareTo('${other.runtimeType}'),
+    () {
+      if (this is PerfectQuality && other is ImperfectQuality) {
+        return 1;
+      }
+      if (this is ImperfectQuality && other is PerfectQuality) {
+        return -1;
+      }
+      return 0;
+    },
   ]);
 }