Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHRAS-4084 : workers - cancel a workers jobs if error is "record not found" #4531

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aynsix
Copy link
Collaborator

@aynsix aynsix commented Jul 9, 2024

Changelog

Fixes

  • PHRAS-4084: workers - cancel a workers jobs if error is "record not found"

}

$body = json_decode($body, true);
if (json_last_error() !== JSON_ERROR_NONE) {
$output->writeln('<error>Invalid message body</error>');

return;
return 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not returning a error code ? (1 ?) see: https://hpc-discourse.usc.edu/t/exit-codes-and-their-meanings/414

same thing todo for every failure point (catch's)

@nmaillat nmaillat added the DO_NOT_MERGE for tests only; please pull label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.1 Discussion DO_NOT_MERGE for tests only; please pull
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants