Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mobile splash page with buttons to trigger auth flow #1000

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

iykazrji
Copy link
Collaborator

@iykazrji iykazrji commented Sep 30, 2024

Pull Request Checklist

Demo

https://www.loom.com/share/56c6ee313e4f45f7bbbb98e99ee7f872?sid=e11262e6-efb9-4764-a6ba-b1c763383399

Testing Guide

  • View the UI Demo app in a mobile window (using chrome tools, you can specify the device dimensions you want to test in.
  • You should see the mobile splash screen implementation
  • The Try It button should prompt the user to login showing the auth card in a bottom sheet view.
  • The various docs links should link accordingly.

Note.

A successful login would show a logout button as the rest of the mobile implementation isn't present in this PR.


PR-Codex overview

This PR primarily focuses on enhancing the UI of the application by adjusting styles, adding a new MobileSplashPage component, and implementing authentication modal functionality.

Detailed summary

  • Updated borderRadius utilities in borders.ts.
  • Modified padding in TopNav component.
  • Added MobileSplashPage component with a gradient header and image.
  • Integrated authentication modal in MobileSplashPage.
  • Included a logout button in the main app layout for user management.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 10:10pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 10:10pm

moldy530
moldy530 previously approved these changes Oct 1, 2024
Copy link
Collaborator

@moldy530 moldy530 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally LGTM, I've updated the linter to finally run on the demo app, so make sure to run yarn lint:write from root

@iykazrji iykazrji merged commit aac08ab into main Oct 2, 2024
6 checks passed
@iykazrji iykazrji deleted the iyk/demo-mobile-landing-page branch October 2, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants