feat: handle passkey signup oauth #1139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moldy530
requested review from
rthomare,
dancoombs,
mokok123,
dphilipson and
linnall
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “graphite-merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
moldy530
commented
Nov 8, 2024
moldy530
commented
Nov 8, 2024
moldy530
commented
Nov 8, 2024
moldy530
commented
Nov 8, 2024
account-kit/signer/src/signer.ts
Outdated
| @@ -128,6 +136,8 @@ export class AlchemyWebSigner extends BaseAlchemySigner<AlchemySignerWebClient> | |||
|
|
|||
| super({ client, sessionConfig, initialError }); | |||
|
|
|||
| this.isSignup = _isSignup === "true" ? true : false; | |||
There was a problem hiding this comment.
we'll come back this, but we will want to propagate signup up via one of the status events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR focuses on enhancing user signup experiences by integrating new user handling and modifying authentication flows, particularly around social logins and passkey creation.
Detailed summary
createPasskeyAfteroption incontext.ts.popuptoredirectinsections.ts.newUserSignupevent intypes.tsandbase.ts.usePrevioushook inusePrevious.ts.clientIdinindex.ts.useNewUserSignupEffectinuseNewUserSignup.tsfor signup handling.oauthCallbackUrlinconfig.tsx.AuthModalto handle new user signup and passkey creation.CompletingOAuthto check forcreatePasskeyAfter.AuthParamsto includeisNewUserinsigner.ts.AuthCardContentto manage authentication state and disconnect logic based on user connection status.