-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: oauth add passkey after signup (redirect flow) #1140
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “graphite-merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! Left a few comments.
Co-authored-by: Michael Moldoveanu <michael.moldoveanu@alchemy.com>
Co-authored-by: Michael Moldoveanu <michael.moldoveanu@alchemy.com>
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR introduces enhancements to user signup flow, particularly focusing on handling new users and passkey creation. It adds new event listeners, modifies existing components, and updates state management to improve user experience during authentication.
Detailed summary
createPasskeyAfter
option to the authentication context.newUserSignup
event inAlchemySignerEvents
.useNewUserSignup
hook to handle new user signups.AuthModal
to open for passkey creation if required.useBreakpoint
to returnundefined
for initial state.BaseAlchemySigner
to manageisNewUser
state.AuthCardContent
to handle authentication state based onisConnected
.