Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: oauth add passkey after signup (redirect flow) #1140

Merged
merged 36 commits into from
Nov 13, 2024

Conversation

linnall
Copy link
Collaborator

@linnall linnall commented Nov 8, 2024

Pull Request Checklist


PR-Codex overview

This PR introduces enhancements to user signup flow, particularly focusing on handling new users and passkey creation. It adds new event listeners, modifies existing components, and updates state management to improve user experience during authentication.

Detailed summary

  • Added createPasskeyAfter option to the authentication context.
  • Introduced newUserSignup event in AlchemySignerEvents.
  • Updated useNewUserSignup hook to handle new user signups.
  • Modified AuthModal to open for passkey creation if required.
  • Changed useBreakpoint to return undefined for initial state.
  • Enhanced BaseAlchemySigner to manage isNewUser state.
  • Updated AuthCardContent to handle authentication state based on isConnected.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 6:17pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 6:17pm

Copy link

graphite-app bot commented Nov 8, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “graphite-merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@linnall linnall changed the title feat: oauth add passkey after signup feat: oauth add passkey after signup redirect flow Nov 8, 2024
@linnall linnall changed the title feat: oauth add passkey after signup redirect flow feat: oauth add passkey after signup (redirect flow) Nov 8, 2024
Copy link
Contributor

@dphilipson dphilipson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! Left a few comments.

account-kit/react/src/components/auth/card/index.tsx Outdated Show resolved Hide resolved
account-kit/react/src/components/auth/hooks/usePrevious.ts Outdated Show resolved Hide resolved
account-kit/react/src/hooks/internal/useNewUserSignup.ts Outdated Show resolved Hide resolved
account-kit/react/src/hooks/internal/useNewUserSignup.ts Outdated Show resolved Hide resolved
linnall and others added 2 commits November 13, 2024 10:35
Co-authored-by: Michael Moldoveanu <michael.moldoveanu@alchemy.com>
Co-authored-by: Michael Moldoveanu <michael.moldoveanu@alchemy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants