feat: improve OAuth error handling #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dphilipson
requested review from
moldy530,
rthomare,
dancoombs and
mokok123
as code owners
|
You must have Developer access to commit code to Alchemy on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes. Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles |
rthomare
previously approved these changes
Sep 25, 2024
moldy530
reviewed
Sep 25, 2024
dphilipson
force-pushed
the
dp/custom-oauth-cancelled-error
branch
from
d83c0bc
to
6aba1b9
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dphilipson
force-pushed
the
dp/custom-oauth-cancelled-error
branch
from
6aba1b9
to
7f1ce9e
Compare
Correctly read errors returned from the callback site. Also use a custom error type, `OauthCancelledError`, when the OAuth flow is cancelled because a user closed the popup window.
dphilipson
force-pushed
the
dp/custom-oauth-cancelled-error
branch
from
7f1ce9e
to
1612981
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly read errors returned from the callback site. Also use a custom error type,
OauthCancelledError, when the OAuth flow is cancelled because a user closed the popup window.PR-Codex overview
This PR introduces new error handling for the OAuth flow in the
AlchemySignerWebClient, adding two error classes:OauthCancelledErrorandOauthFailedError. It also updates the export structure to include these new errors.Detailed summary
account-kit/signer/src/index.tsto includeOauthCancelledErrorandOauthFailedError.OauthCancelledErrorclass extendingBaseErrorwith a constructor message for cancellation.OauthFailedErrorclass extendingBaseErrorfor errors during OAuth login.AlchemySignerWebClientto use the new error classes for handling OAuth errors.