-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use updated error state icons in authCard #986
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
iykazrji
requested review from
moldy530,
rthomare,
dancoombs,
mokok123 and
dphilipson
as code owners
September 26, 2024 21:48
iykazrji
changed the title
Lazer/update error state icons
feat: update error state icons
Sep 27, 2024
iykazrji
changed the title
feat: update error state icons
feat: use updated error state icons in authCard
Sep 27, 2024
moldy530
reviewed
Sep 27, 2024
moldy530
reviewed
Sep 27, 2024
account-kit/react/src/components/auth/card/error/icons/wallet-icon.tsx
Outdated
Show resolved
Hide resolved
rthomare
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)Demo
https://www.loom.com/share/032dbc462eb8426b8c1340acebb6540b?sid=577bee4c-00a7-438c-9deb-80d6cacc77fb
https://www.loom.com/share/fdf9c1eff03f4627b5dee2597a138cfd?sid=548a2cbc-624b-4109-8a82-bf3239661b54
Testing Guide
PR-Codex overview
This PR focuses on improving error handling and user feedback in the authentication process, particularly around wallet connections and timeouts. It updates various components to enhance usability and visual feedback.
Detailed summary
timedOutBody
message for better clarity.authStep
prop toLoadingPasskeyAuth
.Footer
component styling.ConnectionError
to useEOAConnector
instead ofwalletType
.WalletIcon
to utilizeEOAConnector
.LoadingPasskeyAuth
.Navigation
.ConnectionFailed
andTimeout
components for better visual representation with new styles.