Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use updated error state icons in authCard #986

Merged
merged 12 commits into from
Sep 28, 2024

Conversation

iykazrji
Copy link
Collaborator

@iykazrji iykazrji commented Sep 26, 2024

Pull Request Checklist

Demo

Testing Guide

  • From the AuthCard:
    • Simulate a Passkey, Wallet or Timeout error.
    • The error state displayed should match design specs

PR-Codex overview

This PR focuses on improving error handling and user feedback in the authentication process, particularly around wallet connections and timeouts. It updates various components to enhance usability and visual feedback.

Detailed summary

  • Updated timedOutBody message for better clarity.
  • Passed authStep prop to LoadingPasskeyAuth.
  • Simplified Footer component styling.
  • Enhanced ConnectionError to use EOAConnector instead of walletType.
  • Adjusted WalletIcon to utilize EOAConnector.
  • Refined error handling in LoadingPasskeyAuth.
  • Added new SVG icons for connection and timeout errors.
  • Improved styling for button classes in Navigation.
  • Updated ConnectionFailed and Timeout components for better visual representation with new styles.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2024 0:15am
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2024 0:15am

@iykazrji iykazrji marked this pull request as ready for review September 26, 2024 21:48
@iykazrji iykazrji changed the title Lazer/update error state icons feat: update error state icons Sep 27, 2024
@iykazrji iykazrji changed the title feat: update error state icons feat: use updated error state icons in authCard Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants