refactor: switch alchemy client configs to use alchemy transport #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
TODO:
|
moldy530
force-pushed
the
moldy/alchemy-transport
branch
2 times, most recently
from
357b010
to
64a6405
Compare
moldy530
commented
Sep 26, 2024
Comment on lines
120
to
121
| fetchOptions.headers = new Headers(fetchOptions.headers); | ||
| fetchOptions.headers.set("Alchemy-AA-Sdk-Version", VERSION); |
There was a problem hiding this comment.
@dphilipson finally fixed the issues in the previous PR doing this: #563 (comment)
moldy530
force-pushed
the
moldy/alchemy-transport
branch
from
64a6405
to
b7941c4
Compare
moldy530
force-pushed
the
moldy/alchemy-transport
branch
from
b7941c4
to
9dd6d0b
Compare
moldy530
force-pushed
the
moldy/alchemy-transport
branch
2 times, most recently
from
579cacf
to
fd7bca0
Compare
moldy530
force-pushed
the
moldy/alchemy-transport
branch
from
fd7bca0
to
affecef
Compare
moldy530
force-pushed
the
moldy/alchemy-transport
branch
from
affecef
to
69a89cc
Compare
moldy530
force-pushed
the
moldy/alchemy-transport
branch
from
69a89cc
to
c2449f1
Compare
moldy530
commented
Sep 27, 2024
Comment on lines
+82
to
+85
| const pConn = persistedConnection as Record<string, any>; | ||
| if (key === "chain") return value.id === pConn.chain.id; | ||
|
|
||
| return pConn[key] === value; |
There was a problem hiding this comment.
yaayyy testing, we need to get better at our coverage here. it's really bad (I take a lot of the blame for that) and this core logic does a lot of complex state mgmt that needs to be tested
moldy530
commented
Sep 27, 2024
| // this is the default merge behavior | ||
| return { ...current, ...persistedState }; | ||
| const { chain, ...connection } = persistedConnections.find( | ||
| (x) => x.chain.id === persistedState.bundlerClient.chain.id |
There was a problem hiding this comment.
it's fine to use the persisted state here because we've already established the persisted client uses the same connections as the core state. this way if a user has switched chains that switch persists (see tests above)
moldy530
commented
Sep 27, 2024
moldy530
force-pushed
the
moldy/alchemy-transport
branch
from
c2449f1
to
01bcfe3
Compare
moldy530
force-pushed
the
moldy/alchemy-transport
branch
from
01bcfe3
to
867c55f
Compare
moldy530
force-pushed
the
moldy/alchemy-transport-0
branch
from
e1ebd1b
to
3a78277
Compare
moldy530
force-pushed
the
moldy/alchemy-transport
branch
from
867c55f
to
9de5775
Compare
|
Gonna do the docs in a separate PR to keep this one from getting any bigger than it already is |
moldy530
requested review from
rthomare,
dancoombs,
mokok123 and
dphilipson
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR introduces significant updates to the
account-kitlibrary, primarily focusing on the integration ofalchemytransport for smart account clients, enhancing the functionality and configuration of various client creation methods, and refining type definitions for better clarity.Detailed summary
createAlchemySmartAccountClientFromExistingfunction.alchemytransport integration in client creation methods.getSmartAccountClientto utilize new transport methods.watchSmartAccountClient.jsdomenvironment.