feat: add alchemyTransport to use in other places #990
+458
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moldy530
requested review from
rthomare,
dancoombs,
mokok123 and
dphilipson
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
moldy530
force-pushed
the
moldy/alchemy-transport-0
branch
from
e1ebd1b
to
3a78277
Compare
moldy530
commented
Sep 30, 2024
|
|
||
| type SplitTransportConfig = { | ||
| alchemyConnection: ConnectionConfig; | ||
| nodeRpcUrl: string; |
There was a problem hiding this comment.
I'm wondering if this should actually be called nodeTransport and take in a viem Transport type instead. That would allow devs more freedom, but the instantiation looks wilder.
There was a problem hiding this comment.
I'm a fan of passing the transport to escape hatch ourselves from upstream requests. Can we wrap a helper function to create a transport with the nodeRPCUrl? Is that much different than just the normal http(...)?
rthomare
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR introduces the
alchemytransport method to the@account-kit/infralibrary, along with corresponding tests and documentation. It enhances the framework by allowing users to create transport configurations for interacting with Alchemy's API.Detailed summary
alchemyexport toindex.ts.alchemyTransport.jswith transport creation logic and configuration types.alchemyinalchemyTransport.test.ts.alchemymethod inalchemy.mdx.