-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: toast #991
Merged
feat: toast #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobChangCA
requested review from
moldy530,
rthomare,
dancoombs,
mokok123 and
dphilipson
as code owners
September 27, 2024 21:58
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rthomare
reviewed
Sep 30, 2024
RobChangCA
force-pushed
the
rob/toast
branch
from
September 30, 2024 15:32
385e539
to
9b6236a
Compare
RobChangCA
force-pushed
the
rob/toast
branch
from
September 30, 2024 20:59
07c0630
to
eeddc24
Compare
rthomare
reviewed
Oct 1, 2024
rthomare
reviewed
Oct 1, 2024
rthomare
reviewed
Oct 1, 2024
rthomare
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)Description
Adds a toast component to display a success / error when transferring and NFT.
Testing steps
Attempt to transfer an NFT, on success you should see a green toast appear on top of the white nav bar.
You can click the X next to the toast to dismiss it early. It will naturally dismiss after 4 seconds.
This toast is not themeable as the nav bar is always white.
PR-Codex overview
This PR introduces a
Toast
notification system using@radix-ui/react-toast
. It adds aToastProvider
, updates the UI components to utilize the toast functionality, and implements animations for toast visibility.Detailed summary
@radix-ui/react-toast
dependency.ToastProvider
inToastProvider.tsx
.useToast
hook inuseToast.tsx
.Toast
component for displaying notifications.MintCard
for success/error messages.globals.css
.XIcon
component for closing the toast.