fix: ensure openid is included in custom scopes #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dphilipson
requested review from
moldy530,
rthomare,
dancoombs and
mokok123
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dphilipson
force-pushed
the
dp/ensure-openid-scope
branch
from
ab4459b
to
cd0e8c9
Compare
rthomare
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR introduces a new function to ensure the
openidscope is included in the OAuth flow, enhancing compliance with the OIDC protocol.Detailed summary
addOpenIdIfAbsentto check and prependopenidto the provided scope if it is missing.scopeto use the newaddOpenIdIfAbsentfunction whenprovidedScopeis available.