-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compliance): add compliance for STO-040/041 #503
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
0xfourzerofour
requested review from
dancoombs,
dphilipson and
alex-miao
as code owners
November 16, 2023 21:34
alex-miao
reviewed
Nov 17, 2023
alex-miao
reviewed
Nov 17, 2023
alex-miao
reviewed
Nov 17, 2023
0xfourzerofour
force-pushed
the
josh/448
branch
from
November 20, 2023 16:23
27ab7ad
to
355888b
Compare
0xfourzerofour
changed the title
feat(compliance): add compliance for STO-40
feat(compliance): add compliance for STO-040/041
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #448
Proposed Changes
Discussion
I added a simple struct to be used within the count_by_address hashmap so that we can keep track of the different entity types within the mempool with the same address.
https://github.com/eth-infinitism/bundler/blob/main/packages/bundler/src/modules/MempoolManager.ts#L146C11-L146C38
Reference bundler logic