Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compliance): add compliance for STO-040/041 #503

Closed
wants to merge 18 commits into from
Closed

Conversation

0xfourzerofour
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour commented Nov 16, 2023

Closes #448

Proposed Changes

  • Add compliance for sto-041 and sto-040

Discussion

I added a simple struct to be used within the count_by_address hashmap so that we can keep track of the different entity types within the mempool with the same address.

https://github.com/eth-infinitism/bundler/blob/main/packages/bundler/src/modules/MempoolManager.ts#L146C11-L146C38

Reference bundler logic

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #503 (351a1ef) into main (a809894) will increase coverage by 0.05%.
The diff coverage is 69.35%.

Additional details and impacted files

Impacted file tree graph

Files Coverage Δ
crates/pool/src/mempool/error.rs 72.22% <ø> (ø)
crates/pool/src/mempool/mod.rs 98.71% <ø> (ø)
crates/pool/src/mempool/uo_pool.rs 86.55% <100.00%> (+0.13%) ⬆️
crates/sim/src/simulation/simulation.rs 86.13% <100.00%> (+0.10%) ⬆️
crates/sim/src/simulation/tracer.rs 33.80% <100.00%> (+2.92%) ⬆️
crates/pool/src/mempool/entity_tracker.rs 88.88% <88.88%> (ø)
crates/rpc/src/eth/error.rs 0.00% <0.00%> (ø)
crates/pool/src/mempool/pool.rs 95.73% <79.62%> (-1.54%) ⬇️
crates/pool/src/server/remote/error.rs 16.12% <0.00%> (-0.61%) ⬇️
Flag Coverage Δ
unit-tests 53.93% <69.35%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 51.00% <ø> (ø)
dev 0.00% <ø> (ø)
pool 58.88% <70.00%> (+0.06%) ⬆️
provider 0.65% <ø> (ø)
rpc 17.90% <0.00%> (-0.10%) ⬇️
sim 84.97% <100.00%> (+0.03%) ⬆️
tasks ∅ <ø> (∅)
types 91.72% <ø> (ø)
utils 6.92% <ø> (ø)

@0xfourzerofour 0xfourzerofour marked this pull request as ready for review November 16, 2023 21:34
@0xfourzerofour 0xfourzerofour changed the title feat(compliance): add compliance for STO-40 feat(compliance): add compliance for STO-040/041 Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[spec] STO-040/041
2 participants