Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sim): update simulation for dencun opcodes #711

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

dancoombs
Copy link
Collaborator

Proposed Changes

  • Add a new Opcode class, copied from ethers-rs but adds new opcodes (can remove if PR accepted next release)
  • Update geth in testing to 1.14

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 26.66667% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 55.23%. Comparing base (02af869) to head (bf6b835).

Additional details and impacted files

Impacted file tree graph

Files Coverage Δ
crates/builder/src/bundle_proposer.rs 89.04% <100.00%> (ø)
crates/pool/src/server/remote/error.rs 14.80% <ø> (ø)
crates/rpc/src/eth/error.rs 0.00% <ø> (ø)
crates/sim/src/simulation/context.rs 81.94% <ø> (ø)
crates/sim/src/simulation/mempool.rs 94.00% <ø> (ø)
crates/sim/src/simulation/simulator.rs 83.35% <ø> (ø)
crates/sim/src/simulation/v0_7/context.rs 0.00% <ø> (ø)
crates/sim/src/simulation/v0_7/tracer.rs 0.00% <ø> (ø)
crates/types/src/opcode.rs 4.76% <8.33%> (+4.76%) ⬆️
Flag Coverage Δ
unit-tests 55.23% <26.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 50.00% <100.00%> (ø)
dev 0.00% <ø> (ø)
pool 64.50% <ø> (ø)
provider 16.68% <ø> (ø)
rpc 25.67% <ø> (ø)
sim 77.99% <ø> (ø)
tasks ∅ <ø> (∅)
types 65.88% <8.33%> (-0.39%) ⬇️
utils 18.28% <ø> (ø)

Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice, the opcode type is clean

@dancoombs dancoombs merged commit 332d241 into main May 24, 2024
7 checks passed
@dancoombs dancoombs deleted the danc/dencun branch May 24, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants