Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(builder): large refactor of bundle sender state machine and metrics #721

Merged
merged 1 commit into from
Jun 18, 2024
Merged

refactor(builder): large refactor of bundle sender state machine and metrics #721

merged 1 commit into from
Jun 18, 2024

Conversation

dancoombs
Copy link
Collaborator

Proposed Changes

  • Refactor state machine
  • Refactor metrics by saving an object with common components

@codecov Codecov
Copy link

codecov bot commented Jun 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 310 lines in your changes missing coverage. Please review.

Project coverage is 54.37%. Comparing base (a908eef) to head (3bb74c4).

Additional details and impacted files

Impacted file tree graph

Files Coverage Δ
crates/builder/src/server/local.rs 0.00% <ø> (ø)
crates/builder/src/bundle_sender.rs 0.00% <0.00%> (ø)
Flag Coverage Δ
unit-tests 54.37% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 45.75% <0.00%> (-0.48%) ⬇️
dev 0.00% <ø> (ø)
pool 64.37% <ø> (ø)
provider 16.68% <ø> (ø)
rpc 25.67% <ø> (ø)
sim 77.86% <ø> (ø)
tasks ∅ <ø> (∅)
types 65.45% <ø> (ø)
utils 18.28% <ø> (ø)

0xfourzerofour
0xfourzerofour approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just a few comments

crates/builder/src/bundle_sender.rs Show resolved Hide resolved
crates/builder/src/bundle_sender.rs Outdated Show resolved Hide resolved
crates/builder/src/bundle_sender.rs Outdated Show resolved Hide resolved
crates/builder/src/bundle_sender.rs Show resolved Hide resolved
crates/builder/src/bundle_sender.rs Outdated Show resolved Hide resolved
@dancoombs dancoombs merged commit 43fa7ad into danc/sender-cancel Jun 18, 2024
7 checks passed
@dancoombs dancoombs deleted the danc/sender-refactor branch June 18, 2024 21:23
@dancoombs dancoombs mentioned this pull request Jun 18, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xfourzerofour 0xfourzerofour 0xfourzerofour approved these changes

@dphilipson dphilipson Awaiting requested review from dphilipson

@alex-miao alex-miao Awaiting requested review from alex-miao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dancoombs @0xfourzerofour