Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pool): allow staked senders to have multiple UOs in best_operations #726

Closed
wants to merge 4 commits into from

Conversation

dancoombs
Copy link
Collaborator

Closes #251

Proposed Changes

  • Simple change to allow staked accounts to have multiple UOs when calling best_operations on the pool. No changes were needed in the builder to allow for multiple UOs from the same sender in a bundle.
  • Tested this by staking a sender on Arb Sepolia and sending 10 UOs (bundler in manual mode to force them all into a single bundle). Transaction here.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.13%. Comparing base (b39116b) to head (c8f0678).

Additional details and impacted files

Impacted file tree graph

Files Coverage Δ
crates/pool/src/mempool/uo_pool.rs 94.79% <100.00%> (+0.05%) ⬆️
Flag Coverage Δ
unit-tests 54.13% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 45.37% <ø> (ø)
dev 0.00% <ø> (ø)
pool 64.44% <100.00%> (+0.06%) ⬆️
provider 16.10% <ø> (ø)
rpc 25.67% <ø> (ø)
sim 77.86% <ø> (ø)
tasks ∅ <ø> (∅)
types 65.45% <ø> (ø)
utils 18.28% <ø> (ø)

@dancoombs
Copy link
Collaborator Author

Closing in favor of #732

@dancoombs dancoombs closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants