Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tracer): add timeout of 10s to tracer #730

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Conversation

0xfourzerofour
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour commented Jun 18, 2024

Proposed Changes

  • Change timeout of debug_traceCall for custom tracers to 10s instead of the default 5s
  • Add CLI flag to make it customizable

DOCS:
https://geth.ethereum.org/docs/interacting-with-geth/rpc/ns-debug
https://pkg.go.dev/time#ParseDuration

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 20.23810% with 67 lines in your changes missing coverage. Please review.

Project coverage is 55.11%. Comparing base (98f8e2c) to head (27535c6).

Additional details and impacted files

Impacted file tree graph

Files Coverage Δ
crates/sim/src/simulation/context.rs 81.94% <100.00%> (ø)
bin/rundler/src/cli/builder.rs 0.00% <0.00%> (ø)
bin/rundler/src/cli/pool.rs 0.00% <0.00%> (ø)
crates/sim/src/simulation/mod.rs 48.21% <33.33%> (-0.85%) ⬇️
crates/sim/src/simulation/simulator.rs 83.03% <40.00%> (ø)
crates/builder/src/task.rs 0.00% <0.00%> (ø)
crates/sim/src/simulation/v0_6/context.rs 70.47% <63.15%> (-1.75%) ⬇️
crates/sim/src/simulation/v0_7/context.rs 0.00% <0.00%> (ø)
bin/rundler/src/cli/mod.rs 0.00% <0.00%> (ø)
crates/sim/src/simulation/v0_6/tracer.rs 0.00% <0.00%> (ø)
... and 2 more
Flag Coverage Δ
unit-tests 55.11% <20.23%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <0.00%> (ø)
builder 50.00% <0.00%> (ø)
dev 0.00% <ø> (ø)
pool 64.32% <0.00%> (-0.06%) ⬇️
provider 16.68% <ø> (ø)
rpc 25.67% <ø> (ø)
sim 77.49% <29.82%> (-0.38%) ⬇️
tasks ∅ <ø> (∅)
types 65.45% <ø> (ø)
utils 18.28% <ø> (ø)

@@ -27,6 +27,7 @@ dotenv = "0.15.0"
ethers.workspace = true
itertools = "0.12.1"
metrics = "0.22.1"
go-parse-duration = "0.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol I can't believe there is a crate for this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeh I was very surprised as well lol

Copy link
Collaborator

@dancoombs dancoombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@0xfourzerofour 0xfourzerofour merged commit 23da122 into main Jun 18, 2024
8 checks passed
@0xfourzerofour 0xfourzerofour deleted the josh/tracer-timeout branch June 18, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants