Sender fixes #734
Merged
Sender fixes #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancoombs
requested review from
dphilipson,
0xfourzerofour and
alex-miao
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -196,6 +196,17 @@ pub enum OpRejectionReason { | |||
| FailedRevalidation { error: SimulationError }, | |||
| /// Operation reverted during bundle formation simulation with message | |||
| FailedInBundle { message: Arc<String> }, | |||
| /// Operation's storage slot condition was not met | |||
| ConditionNotMet(ConditionNotMetReason), | |||
There was a problem hiding this comment.
ConditionNotMet is a somewhat ambiguous enum name, maybe something like StorageConditionNotMet?
There was a problem hiding this comment.
I feel like its descriptive enough since we have a "Conditional" sender, so this enum is coupled with that name
dphilipson
approved these changes
Jun 19, 2024
dancoombs
force-pushed
the
danc/sender-fixes
branch
from
f01429f
to
e94744a
Compare
0xfourzerofour
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combo of 3 PRs: #725 #722 #723