-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for avax chains #750
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
032d5c1
to
6ed657e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
/// deploy costs that are not metered by the entry point | ||
pub per_user_op_deploy_overhead_gas: U256, | ||
/// Gas cost for a user operation word in a bundle transaction | ||
pub per_user_op_word_gas: U256, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these values ever change across chains
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per_user_op_deploy_overhead_gas
does (Avax). Currently per_user_op_word_gas
, calldata_zero_byte_gas
, and calldata_non_zero_byte_gas
don't, but a simple EVM config change could change that, so kept them configurable with a reasonable default.
- Add gas overheads to chain spec (#638) - Allow for retries in chain sync - Add avax and avas fuji chain specs
Closes #638
Proposed Changes
GasOverheads
to chain spec (or hardcode) #638)