feat: add support for avax chains #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancoombs
requested review from
dphilipson,
0xfourzerofour and
alex-miao
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dancoombs
force-pushed
the
danc/avax
branch
2 times, most recently
from
032d5c1
to
6ed657e
Compare
alex-miao
reviewed
Jul 8, 2024
alex-miao
reviewed
Jul 8, 2024
| /// deploy costs that are not metered by the entry point | ||
| pub per_user_op_deploy_overhead_gas: U256, | ||
| /// Gas cost for a user operation word in a bundle transaction | ||
| pub per_user_op_word_gas: U256, |
There was a problem hiding this comment.
Do these values ever change across chains
There was a problem hiding this comment.
per_user_op_deploy_overhead_gas does (Avax). Currently per_user_op_word_gas, calldata_zero_byte_gas, and calldata_non_zero_byte_gas don't, but a simple EVM config change could change that, so kept them configurable with a reasonable default.
- Add gas overheads to chain spec (#638) - Allow for retries in chain sync - Add avax and avas fuji chain specs
alex-miao
approved these changes
Jul 8, 2024
0xfourzerofour
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #638
Proposed Changes
GasOverheadsto chain spec (or hardcode) #638)