feat(types): modify types to use native u128 where possible #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancoombs
requested review from
dphilipson,
0xfourzerofour,
alex-miao and
andysim3d
as code owners
|
looks good but we need to fix the unit tests and linting |
0xfourzerofour
approved these changes
Sep 12, 2024
| .pre_verification_gas | ||
| .uint_try_to() | ||
| .context("pre verification gas out of bounds")?; | ||
| let pvg: u128 = user_op.pre_verification_gas; |
There was a problem hiding this comment.
nit: we do not need the explicit type definition if its defined at the UO struct
| .pre_verification_gas | ||
| .uint_try_to() | ||
| .context("pre verification gas out of bounds")?; | ||
| let pvg: u128 = user_op.pre_verification_gas; |
| * (self.pre_verification_gas | ||
| + U256::from(self.call_gas_limit) |
There was a problem hiding this comment.
low chance of this happening but if someone inputs an arbitrarily large value for one of these fields we may have an overflow calling function so might be a good idea to saturate.
not sure if this is checked before this but worth the safety
andysim3d
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
preVerificationGaswhich onchain can be a U256. It is assumed there are no use cases where PVG needs to be > u128. We we're already relying on a U256 -> u128 conversion for gas limit calculation anyway.