feat(middleware): add response extractor. #816
+119
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysim3d
requested review from
dancoombs,
dphilipson,
0xfourzerofour and
alex-miao
as code owners
andysim3d
force-pushed
the
andy/repsonse-extractor
branch
2 times, most recently
from
bdb8953
to
ba6d2d0
Compare
andysim3d
force-pushed
the
andy/repsonse-extractor
branch
from
ba6d2d0
to
ba1f0c6
Compare
dancoombs
reviewed
Sep 27, 2024
| @@ -17,3 +17,9 @@ pub trait RequestExtractor<R>: Copy + Sync + Send { | |||
| /// Get method name. | |||
| fn get_method_name(request: &R) -> String; | |||
| } | |||
|
|
|||
| /// Trait to extract response code. | |||
| pub trait ResponseExtractor<R>: Copy + Sync + Send { | |||
There was a problem hiding this comment.
Does this need to be Copy? Thats a pretty strict bound to put on a trait
dancoombs
reviewed
Sep 27, 2024
| /// Trait to extract response code. | ||
| pub trait ResponseExtractor<R>: Copy + Sync + Send { | ||
| /// Get response code. | ||
| fn get_response_code(response: &R) -> String; |
There was a problem hiding this comment.
Why is the code a string?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Closes/Fixes] #812
Proposed Changes