WIP #817
Merged
WIP #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancoombs
commented
Sep 27, 2024
| ); | ||
|
|
||
| let start = Instant::now(); | ||
| let mut svc = self.inner.clone(); | ||
| let service_name = self.service_name.clone(); | ||
| let protocal = self.protocal.clone(); | ||
| let protocal = self.protocol.clone(); |
There was a problem hiding this comment.
Typo here still protocol
dancoombs
commented
Sep 27, 2024
| } | ||
| } | ||
|
|
||
| impl<T, R> Clone for MetricsLayer<T, R> |
There was a problem hiding this comment.
Needed to manually implement clone because derive(Clone) requires that T, R be Clone, where they don't need to be since we're using phantom data.
dancoombs
commented
Sep 27, 2024
| _request_type: PhantomData<R>, | ||
| } | ||
|
|
||
| impl<S, T, R> Clone for MetricsMiddleware<S, T, R> |
There was a problem hiding this comment.
Same reason here
dancoombs
commented
Sep 27, 2024
Comment on lines
+117
to
+120
| S: Service<R> + Send + Clone + 'static, | ||
| S::Future: Send + 'static, | ||
| T: RequestExtractor<R> + 'static, | ||
| R: Send + 'static, |
There was a problem hiding this comment.
Removed all of the Sync from these bounds as its not required by Service. Tbh I'm unsure why but this made the compiler happy, example here https://github.com/hyperium/tonic/blob/master/examples/src/tower/server.rs
dancoombs
commented
Sep 27, 2024
Comment on lines
+147
to
+149
| &method_name, | ||
| &service_name, | ||
| &protocal, |
There was a problem hiding this comment.
Very common to convert String -> &str with a dereference
andysim3d
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Closes/Fixes] #
Proposed Changes