Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move limits to providers, add da to limit #831

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

dancoombs
Copy link
Collaborator

Closes: #783

Proposed Changes

  • Move usage of max_verification_gas and max_simulate_handle_ops_gas as gas limits to the entry point providers
  • Add DA gas limit to the gas limit, where necessary
  • Remove unneeded PVG checks

Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@dancoombs dancoombs merged commit 5b44cb9 into feat/v0.4 Oct 8, 2024
7 checks passed
@dancoombs dancoombs deleted the danc/fix-pvg-limit branch October 8, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sim] Correctly handle PVG and gas limits during simulation/estimation calls
2 participants