-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pool): add da tracking to pool #847
Conversation
0dcb089
to
bafb3c3
Compare
Tests to be added in this ticket #845 |
bafb3c3
to
81651df
Compare
Filled a mempool on my laptop on op-sepolia with 1000 UOs, the pool maintenance call took < 5ms. I'd expect it to be closer to 1-2ms on good/isolated hardware. So I don't think we have a performance problem with the pool maintenance loops. Not going to do anything there for now. If we eventually see issues we have 2 levers to pull: (1) optimize the code (2) move to rayon blocking pool. |
45e6858
to
e5086cd
Compare
e5086cd
to
e53c769
Compare
Also closes #859 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good just a couple comments
Closes #744
Proposed Changes
da_gas_tracking_enabled
CLI parameter.(can this be removed?)TODO
Determine if we can remove the builder PVG checkDecided the builder must keep this, as it may raise the fees compared to the initial fees used by the mempool.do_maintenance
call on the pool when under heavy loadMore tests[provider] Add more unit test for cached DA oracles #845