Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): remove windows build #902

Merged
merged 1 commit into from
Nov 5, 2024
Merged

chore(ci): remove windows build #902

merged 1 commit into from
Nov 5, 2024
+9 −10

Conversation

dancoombs
Copy link
Collaborator

No description provided.

0xfourzerofour
0xfourzerofour reviewed Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also remove the check for windows on the Move cross-compiled binary step that changes the extension to .exe

0xfourzerofour
0xfourzerofour approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@dancoombs dancoombs merged commit a92183b into main Nov 5, 2024
17 checks passed
@dancoombs dancoombs deleted the danc/remove-windows branch November 5, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xfourzerofour 0xfourzerofour 0xfourzerofour approved these changes

@dphilipson dphilipson Awaiting requested review from dphilipson dphilipson is a code owner

@alex-miao alex-miao Awaiting requested review from alex-miao alex-miao is a code owner

@andysim3d andysim3d Awaiting requested review from andysim3d andysim3d is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dancoombs @0xfourzerofour