Attempt to fix autocomplete for strings that start with "$" #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review as I was not able to successfully build due to issue unrelated to this code
When typing out variables in the IDE that start with
$
, for example$clog
, autocomplete will correctly suggest possibilities, but when replacing the variable it will not properly identify the start as$
and will replace the text creating a double first character:$$clog
.I was not able to get the IDE to build from the current code. IntelliJ was not happy with it and gave lots of errors when trying to build. A pom.xml or other build manifest would be helpful for this.
I did do some testing to compare
Character.isLetterOrDigit
totext.charAt(start) == '$'
in the console:Considering that there was already an exception for text that starts with
_
, I hope that an additional check for$
will fix this issue. If it will not, please reject this PR. I may have misunderstood why the additional check for_
is required.