Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assume the assets held by the wrapper are the loan #12

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

alcueca
Copy link
Owner

@alcueca alcueca commented Aug 7, 2023

Previously, if the wrapper held any assets before the call, the wrapper would think they are part of the loan and would pass an inflated amount to repay to the borrower.

src/uniswapV3/UniswapV3Wrapper.sol Outdated Show resolved Hide resolved
@alcueca alcueca merged commit a9ea128 into main Aug 8, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants