WIP: Code tweaks #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ultrasecreth
commented
Jul 30, 2023
ultrasecreth
commented
- Use a struct fro the meta params in the aave wrapper
- Use a struct fro the meta params in the balancer wrapper
- Use a struct fro the meta params in the uniswap wrapper
alcueca
approved these changes
Aug 1, 2023
| @@ -57,97 +80,44 @@ contract UniswapV3Wrapper is IERC3156PPFlashLender, IUniswapV3FlashCallback { | |||
| * @return The amount of `asset` to be charged for the loan, on top of the returned principal. | |||
| */ | |||
| function flashFee(IERC20 asset, uint256 amount) public view override returns (uint256) { | |||
| address pool = address(getPool(asset)); | |||
There was a problem hiding this comment.
The natspec above can be copied from a wrapper that has it correct.
|
|
||
| bytes internal _callbackResult; | ||
|
|
||
| /// @inheritdoc IERC3156PPFlashLender |
There was a problem hiding this comment.
We should @inheritdoc from the ERC7399 interface when possible, I think.
There was a problem hiding this comment.
Where does that interface lives? I can't see it in the deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.